electron-userland / electron-compilers

DEPRECATED: Compiler implementations for electron-compile
35 stars 55 forks source link

Use exports.default if _default is not defined, fixes #64 for typescript on es2017 target #70

Closed fasterthanlime closed 7 years ago

fasterthanlime commented 7 years ago

cf. this comment

I feel bad about this, #64 was merged after I confirmed it worked for me when in fact.. I was probably misled by the cache? Sorry about that 😞

(Note that this will break if you manually define a variable named _default that isn't your default export but that's just the price to pay for babel compat I suppose?)

anaisbetts commented 7 years ago

I merged the revert to unbork people, can you rebase this against master (revert the revert first, then cherry-pick this)?

fasterthanlime commented 7 years ago

@paulcbetts done