Fix sass imports - Githubissues

electron-userland / electron-compilers

DEPRECATED: Compiler implementations for electron-compile

35 stars 55 forks source link

Fix sass imports #75

Open alexstrat opened 7 years ago

alexstrat commented 7 years ago

paths is not a valid option to pass to sass.js (see https://github.com/electron/electron-compilers/pull/55#issuecomment-304724319) -> remove it before passing compilerOptions to sass.js
fix import's path resolution

Those 2 fixes worked on my project.

alexstrat commented 7 years ago

@paulcbetts @saschagehlich do you think you could review these changes?

saschagehlich commented 7 years ago

Sorry man, I'm not responsible for this repository. :(

alreece45 commented 7 years ago

@alexstrat I'm not a contributor here, the paths fix is simple enough, but the second change doesn't seem as obvious to me. Is the current code removing /sass/ from the path, even when it isn't supposed to?

It may be beneficial to have that as a separate request-- but I'm not responsible for this repository, either.

Tenrys commented 6 years ago

This should fix nested imports, right? Trying to load the entirety of bulma gets pretty broken right now, file paths seem broken. @import "node_modules/bulma/bulma" works, @import "sass/utilities/_all" inside of the file doesn't, seemingly because of resolved path issue.