typescript+babel and coverage improvements

electron-userland / electron-compilers

DEPRECATED: Compiler implementations for electron-compile

35 stars 52 forks source link

typescript+babel and coverage improvements #77

Open fasterthanlime opened 7 years ago

fasterthanlime commented 7 years ago

See https://github.com/electron/electron-compilers/issues/76

Drop istanbul@0.4.5 dependency, add babel-plugin-istanbul
Add getEnv() helper to SimpleCompilerBase
Support an environment string in the coverage option for both typescript and babel compilers
Make babel compiler use compilerContext as compile options
Drop sorcery dependency, pass inputSourceMap to babel instead
Always use babel+babel-plugin-istanbul to instrument code for measuring coverage
In ts+babel, translate ts sourcemap options to babel. With a twist, for inline sourcemaps.

fasterthanlime commented 7 years ago

Quick update: using context to pass inputSourceMap breaks the inline html compiler. Fixing now

fasterthanlime commented 7 years ago

Quick update: using context to pass inputSourceMap breaks the inline html compiler. Fixing now

Fixed in https://github.com/electron/electron-compilers/pull/77/commits/262476a5939ac545f62f5ea83e6fcf6127c2e152

fasterthanlime commented 7 years ago

Another quick change I'm about to make: forward coverageInclude and coverageExclude keys to babel-plugin-instrument.

It's not possible to use the nyc block in package.json method unfortunately, because inputSourceMap is already passed directly to babel-plugin-instrument, so it doesn't even look at the package.json.

fasterthanlime commented 7 years ago

Latest semantics:

code is only ever instrumented in testing (if you can think of a use case where one would like code to be instrumented in a non-test environment, let me know).
coverage: true does the same thing as before (except only in test)
coverage: { /* opts */ } passes options to babel-plugin-istanbul, like include and exclude, see documentation in https://github.com/fasterthanlime/electron-compile/commit/4b232377bb47a81f80c87e3ace1a8e4b88d6cedb

fasterthanlime commented 7 years ago

New find! While babel:

will accept an inputSourceMap
will merge/combine/remap sourcemaps correctly
does have a sourceMaps: "inline" option

...if you specify inputSourceMap, sourceMaps is forced to true rather than "inline", so if you enable coverage on my branch, you don't get inline source maps. Fixing that now.