search

electron-userland / electron-compilers

DEPRECATED: Compiler implementations for electron-compile
35 stars 55 forks source link

Support `esModuleInterop` option from TypeScript 2.7 #88

Open kestred opened 6 years ago

kestred commented 6 years ago

The typescript compiler seems to ignore or stomp on this configuration option.

Making this available should reduce ecosystem compatibility problems; I suspect it will address the issues in https://github.com/electron-userland/electron-compile/issues/294.

cwmoo740 commented 6 years ago

It looks like that electron-compilers never loads the root project's tsconfig.json.

kestred commented 6 years ago

@cwmoo740: it doesn't; it parses the typescript compiler options out of .compilerc, which is as intended I think?

danguilherme commented 5 years ago

Did you manage to get it working? esModuleInterop just seems to be ignored in my config. I saw the issue #89, but different from the title, the TypeScript version was changed to >=1.7 (and also, it looks like the change is not on npm).

danguilherme commented 5 years ago

Nevermind, I got it working. The problem was that my config file, .compilerc.json, was not being loaded, probably because of this issue: https://github.com/electron-userland/electron-compile/issues/147.

To get this over with I just renamed the file to .compilerc, and it worked.