This PR adds support for .ejs files to electron-compilers.
Used the GraphQL PR as a reference for what files to change.
Used the JadeCompiler as a starting template for this compiler, as their syntax for loading files looked very similar. However, I was not familiar with the sourceMap usage, so I removed it, however it can be added back in if needed.
Since ejs allows you to pass in data, and those familiar with other ejs electron packages are used to being able to provide data and options, I added this to the compiler. I'm not quite sure the best way to make it possible however. One way seemed to access globalCompilerHost.compilersByMimeType.ejs.data, but I would appreciate any feedback or thoughts on this.
I'm also not sure how it will handle caching, as ejs files are able to include() other ejs files.
Hi,
This PR adds support for
.ejsfiles toelectron-compilers.Used the GraphQL PR as a reference for what files to change.
Used the JadeCompiler as a starting template for this compiler, as their syntax for loading files looked very similar. However, I was not familiar with the
sourceMapusage, so I removed it, however it can be added back in if needed.Since ejs allows you to pass in data, and those familiar with other ejs electron packages are used to being able to provide data and options, I added this to the compiler. I'm not quite sure the best way to make it possible however. One way seemed to access
globalCompilerHost.compilersByMimeType.ejs.data, but I would appreciate any feedback or thoughts on this.I'm also not sure how it will handle caching, as ejs files are able to
include()other ejs files.