Closed nelsonjchen closed 5 years ago
While #31 resolves the react-typescript
situation, as mentioned in #31, another PR should be made against the angular 2 version too.
It would be most helpful if someone more familiar with Angular 2 could make the PR.
Please describe your issue:
It doesn't appear the
lint
task work in the generated projects. For example, right away there's an issue with thecurly
rule warning not popping up forsrc/index.ts
.Please provide either a failing minimal testcase (with a link to the code) or detailed steps to reproduce your problem.
Run this:
Now open
foobar-project/src/index.ts
in something that'stslint
aware like VS Code. You'll immediate see there's a linting error on about line 11, where there's no curly braces for the live reload check. That is, by the way, a separate issue.Now run
yarn lint
or anything that runs thelint
task. No lint warnings appears. If you go into either of thetsx
orts
files and start putting stuff in them clearly out of style, thelint
task will give no warnings. In fact, you can replaceindex.ts
with the US constitution or anything that's not valid code and it won't be read either.I think the issue is that the
lint
task resolves totslint src
and that does not appear to recursively lint.ts
or.tsx
files undernearthsrc
. Running something explicit likeyarn lint -- src/index.ts
does get the linter to respond to the file on disk.