search

electron-userland / electron-installer-dmg

Create DMG installers for your electron apps using appdmg.
https://github.com/electron-userland/electron-installer-dmg
Apache License 2.0
316 stars 39 forks source link

refactor: convert to typescript and upgrade Node.js versions #178

Closed MarshallOfSound closed 2 months ago

MarshallOfSound commented 1 year ago

Converts to typescript so that forge can just import the options type instead of duplicating it.

This is a breaking change per the commit message, the export is now a named export createDMG and the debug option has been removed because it makes no sense.

codecov[bot] commented 1 year ago

Codecov Report

Attention: Patch coverage is 44.64286% with 31 lines in your changes missing coverage. Please review.

Project coverage is 44.64%. Comparing base (ddc6db7) to head (eec8137). Report is 2 commits behind head on main.

:exclamation: Current head eec8137 differs from pull request most recent head 001ed46

Please upload reports for the commit 001ed46 to get more accurate results.

Files Patch % Lines
src/index.ts 44.64% 19 Missing and 12 partials :warning:

:exclamation: There is a different number of reports uploaded between BASE (ddc6db7) and HEAD (eec8137). Click for more details.

HEAD has 3 uploads less than BASE | Flag | BASE (ddc6db7) | HEAD (eec8137) | |------|------|------| ||6|3|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #178 +/- ## =========================================== - Coverage 75.43% 44.64% -30.80% =========================================== Files 1 1 Lines 57 56 -1 Branches 0 18 +18 =========================================== - Hits 43 25 -18 - Misses 14 19 +5 - Partials 0 12 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mahnunchik commented 1 year ago

I'm looking forward to have it merged