search

electron-userland / electron-installer-redhat

Create a Red Hat / RPM package for your Electron app.
MIT License
81 stars 44 forks source link

fix: skip stripping when making RPM for different architecture #325

Closed dsanders11 closed 1 year ago

dsanders11 commented 1 year ago

By default the host's /usr/bin/strip is used, which won't work when executables being stripped are for a different architecture.

dsanders11 commented 1 year ago

I think a better long-term fix to this issue would be to add logic similar to this logic in electron/script/strip-binaries.py which selects the architecture-specific strip binary, and uses it if it's available, otherwise do no stripping. That would allow setups to do stripping in all cases with some additional setup.