search

electron-userland / electron-json-storage

:package: Easily write and read user settings in Electron apps
1.43k stars 79 forks source link

Electron dependency breaks electron-builder via Mac App Store #112

Closed james-criscuolo closed 6 years ago

james-criscuolo commented 6 years ago

The electron dependency introduced here: https://github.com/electron-userland/electron-json-storage/commit/7f035f2cf54038c9c45026d977d8556d45706fc9

Causes node_modules to have multiple electron dependencies, or maybe just 1, but typically this is not here. I didn't mess around much, but even setting it to the same version of electron was causing issues. This causes the pList files generated for the Mac App Store to include multiple references to electron, which is not allowed. Is there any reason this isn't just a peer dependency?

jviotti commented 6 years ago

Hi @james-criscuolo ,

Thanks for the heads up. This should have been a peer dependency, as you pointed out. Can you send a PR for it? I'll merge and publish right away!

james-criscuolo commented 6 years ago

I see another user already covered this in #114, please let me know if there is anything else I can do.

jviotti commented 6 years ago

I published the fix as v4.1.2. I'll close this ticket now, but please let us know how it went :)