Electron Dependencies break electron builder on windows

electron-userland / electron-json-storage

:package: Easily write and read user settings in Electron apps

1.43k stars 79 forks source link

Electron Dependencies break electron builder on windows #113

Closed zhe-db closed 6 years ago

zhe-db commented 6 years ago

Extra files was generated after build process. an electron sample app got packed into /app.asar.unpacked/node_modules/electron-json-storage/node_modules/electron/

a-lizards-breath commented 6 years ago

where did the sample app come from?? Thinking of including this for simple key/val storage in a windows target app, but that sounds.... troubling

jviotti commented 6 years ago

Yeah, electron should have been a peerDependency. Feel free to send a PR :)

Nantris commented 6 years ago

Sent a PR for this earlier. Just mentioning so no one else needlessly does it again.

jviotti commented 6 years ago

I published the fix as v4.1.2. I'll close this ticket now, but please let us know how it went :)

zhe-db commented 6 years ago

@jviotti Thank you.