search

electron-userland / electron-json-storage

:package: Easily write and read user settings in Electron apps
1.43k stars 79 forks source link

The exe becoming double the size even after updating electron-json-storage to 4.1.2 #118

Open GorvGoyl opened 5 years ago

GorvGoyl commented 5 years ago

I looked into the issue https://github.com/electron-userland/electron-json-storage/issues/114 but my electron app is still doubling the size. w/o electron-json-storage: 35 mb w/ electron-json-storage: 71mb

"electron": "^2.0.10", "electron-json-storage": "^4.1.2", "electron-builder": "^19.56.2"

also see result of npm prune:

> npm prune --production
> npm WARN electron-json-storage@4.1.2 requires a peer of electron@^2.0.4 but none is installed. You must install peer dependencies yourself.

Update: issue exist when I used npm, when I used yarn then it indicated that some other modules were needed to update to resolve peerdependency of electron with electron-json-storage. After updating modules in package.json it seems to work fine now. lesson learned: do not use npm, use yarn :P

bingqiao commented 5 years ago

This could be related to: https://github.com/electron-userland/electron-json-storage/issues/120