allow to read file that saved in other encodings then utf-8

electron-userland / electron-json-storage

:package: Easily write and read user settings in Electron apps

1.43k stars 79 forks source link

allow to read file that saved in other encodings then utf-8 #133

Closed bikov closed 5 years ago

bikov commented 5 years ago

In some of our cases we use this package to store configuration and it's very annoying to save the file as utf-8 in every change

jviotti commented 5 years ago

Hey @bikov ,

Sounds great! I think Travis is failing for unrelated reasons. Let me restart and merge/release in a bit.

jviotti commented 5 years ago

@bikov Can you please rebase this PR? I fixed Travis in here: https://github.com/electron-userland/electron-json-storage/pull/134, but I can't rebase your PR myself :)

bikov commented 5 years ago

@bikov Can you please rebase this PR? I fixed Travis in here: #134, but I can't rebase your PR myself :)

Hi. I have merged the PR but looks like continuous-integration/appveyor/branch isn't running at all

jviotti commented 5 years ago

@ckerr, @codebytere, @felixrieseberg, @jkleinsc, @lee-dohm, @malept, @MarshallOfSound, @zcbenz (sorry for the large amount of pings)

Can you please make the continuous-integration/appveyor/branch check in this repository optional, as Appveyor won't trigger the branch job on external PRs (I don't have enough access)?

Thanks a lot! :)

malept commented 5 years ago

You should be able to do that yourself by limiting the branches tested by CI to master (and optionally tagged versions). Here's an example in Electron Packager:

https://github.com/electron/electron-packager/blob/dd1d9b2ee5d5980cea3c1d8424d02fb51ff78739/test/ci/appveyor.yml#L10-L12

jviotti commented 5 years ago

@malept Great tip. I'll try that now. Thanks a lot!

jviotti commented 5 years ago

@malept Hang on, wouldn't that make Appveyor not report status checks on any branch other than master? If so, that won't fix the problem, as this repository expects the branch status check to pass in order for me to be able to merge.

malept commented 5 years ago

I think try it first, and then if it doesn't go away, I'll look into it.

jviotti commented 5 years ago

@malept Check https://github.com/electron-userland/electron-json-storage/pull/135. The branch Appveyor status check is now not triggering even for me, so I can't merge my own PR either:

malept commented 5 years ago

Interesting. OK, I've removed the branch check.

jviotti commented 5 years ago

Thanks a lot @malept!

jviotti commented 5 years ago

@bikov Published as v4.1.7