search

electron-userland / electron-json-storage

:package: Easily write and read user settings in Electron apps
1.43k stars 79 forks source link

async 2.0 has vulnerable issue #177

Open garasubo opened 2 years ago

garasubo commented 2 years ago

async 2.0 includes vulnerability (https://github.com/advisories/GHSA-fwr7-v2mv-hh25). I looked into the usage of async library in this project, and it looked this project didn't use the vulnerable method. However, this caused warning message from npm both in this project and projects using this library.

It will be nice to update >= 3.2.2. There are some breaking changes, but I think it won't affect this project.

garasubo commented 2 years ago

@jviotti Any update on this? #176 or #178 will resolve this issue.

jviotti commented 2 years ago

Thanks @garasubo! The PRs look good, but Travis CI is not kicking-in for this repo for some reason. I'll see if I can make it work. I don't have admin permissions on this repo though, so we will have to contact an admin if I cannot resolve it.

jviotti commented 2 years ago

See https://github.com/electron-userland/welcome/issues/13