search

electron-userland / electron-json-storage

:package: Easily write and read user settings in Electron apps
1.43k stars 79 forks source link

Replace lodash with lodash-es? #194

Open Nantris opened 1 year ago

Nantris commented 1 year ago

This appears to be the only reason that lodash is included in our bundles. It would be great to migrate to the more tree-shakeable lodash-es.

Nantris commented 1 year ago

@jviotti pinging you on this because you seem to be the most active contributor.

A big thanks to you for all the great work!

jviotti commented 1 year ago

Hey @Slapbox ,

Sounds good to me! I haven't heard about lodash-es, but if you can send a quick PR, I'll issue a release ASAP. Thanks a lot!

Nantris commented 1 year ago

@jviotti thanks for your reply!

I found out we actually have two other dependencies that depend on lodash, so this has moved down in priority for us quite a bit, but I'm still open to submitting a PR when I can.

PS thanks for your email - I saw it, but it's going to take me some time to get back to you since it's crunch time here right now.

jviotti commented 1 year ago

No hurries. Sounds good!