search

electron-userland / electron-prebuilt-compile

electron-prebuilt with Babel and React built-in
168 stars 56 forks source link

Missing dependency in electron-compilers #22

Closed mrsimonemms closed 7 years ago

mrsimonemms commented 7 years ago

I've found an issue this morning with a missing dependency @paulcbetts/node-sass inside electron-compilers (see https://github.com/electron/electron-compilers/issues/44 for more detail).

I know this isn't an issue with this package pe se, but I notice that this package pulls in the electron-compilers package with "*" - would it be worth locking down the version numbers so this doesn't happen in future?

For the record, I've solved my specific issue with the following npm-shrinkwrap.json file:

{
  "name": "NodeDB",
  "version": "0.0.0",
  "dependencies": {
    "electron-compilers": {
      "version": "4.0.7"
    }
  }
}
anaisbetts commented 7 years ago

This is fixed now, sorry - the package somehow didn't get marked as public