search

electron-userland / electron-prebuilt-compile

electron-prebuilt with Babel and React built-in
168 stars 56 forks source link

Warning, the following targets are using a decimal version #45

Open archae0pteryx opened 7 years ago

archae0pteryx commented 7 years ago

I just installed via yarn and i'm getting this warning in my console:

Warning, the following targets are using a decimal version:

  electron: 1.6

We recommend using a string for minor/patch versions to avoid numbers like 6.10
getting parsed as 6.1, which can lead to unexpected behavior.

I'm not seeing any quick resolutions via the google. Call me OCD but i'd prefer not to have a warning when i fire up my badass electron-prebuilt-compile based app. How do i go about "using a string for minor/patch versions" ? It seems to me that the version is already a string in my package.json. What don't i know here.

Thanks ya'll

ddavidebor commented 7 years ago

Same! Annoying

timfish commented 6 years ago

This is coming from .compilerc:

"env",
{
  "targets": {
    "electron": 1.7
  }
}

Simply make the version a string:

"electron": "1.7"