Closed jacobq closed 5 years ago
Hey @paulcbetts is something holding this up? Now that Electron 4.0.4 is released with the new ABI version so it works with prebuilt modules again, the only thing blocking me from updating to Electron 4 is an electron-prebuild-compile
4.0.4
release so I can use electron-forge
and ember-electron
with Electron v4.
Electron 4.0.5 is released now and with a security issue fixed in 4.0.4. I think this should be updated. This package should be automated if that is possible. I'm using electron-forge
which cannot update without this being updated. Thanks in advance.
news... ?
Now 3.1.7 and 4.1.1
I think the project will die, see #80.
@reebr Thanks for pointing that out (I wasn't aware). Once electron-forge
v6.x is ready then I can work with the ember-electron
team and drop the requirement. However, in the mean time it would still be nice to get an updated release on NPM to avoid being so out of date during the transition. Unfortunately this type of project is different than many other open source works because forking it does not help due to electron-forge
v5.x's tight coupling with this specific module (i.e. by literal name and version strings in package.json
).
I've been able to work-around this by doing the following:
@jacobq/electron-prebuilt-compile
)npm info @jacobq/electron-prebuilt-compile dist.tarball
to get a URL, e.g.
electron-prebuilt-compile
electron-forge
that you are using includes https://github.com/electron-userland/electron-forge/pull/450 -- e.g. for ember-electron
, I used yarn
selective resolutions to force version 5.2.4 "resolutions": {
"**/broccoli-postcss": "^4.0.1",
"**/electron-forge": "^5.2.4",
"**/node-abi": "^2.7.1"
},
I think this project is effectively abandoned. Closing in favor of fork->scope->tarball work-around
Thanks for the workaround @jacobq. I'm working on an ember-electron project and I have a problem. When I do what you suggest and add" "electron-prebuilt-compile": "https://registry.npmjs.org/@jacobq/electron-prebuilt-compile/-/electron-prebuilt-compile-4.2.0.tgz",
in my package.json file, "npm install" goes well, "npm list" tells me I have what I need, but electron-forge (I think...) complains that: "You must depend on an EXACT version of "electron-prebuilt-compile" not a range" Indeed, it appears a URL is considered as a range, not a pinned version. What am I doing wrong? Thanks!
@verstaen Yes, that's exactly what I had to slog through. It's related to these:
The way I got around it was to use yarn's selective resolution feature and point to forks with my own patches (you can dig in if you want to see the changes). Here's an excerpt from my package.json file:
"devDependencies": {
"electron-prebuilt-compile": "https://registry.npmjs.org/@jacobq/electron-prebuilt-compile/-/electron-prebuilt-compile-5.0.1.tgz",
"ember-electron": "adopted-ember-addons/ember-electron#34d20f76a3ee3e58e2bbbb5452cc48d9e1fa2983"
},
"dependencies": {
"electron-forge": "https://registry.npmjs.org/@jacobq/electron-forge/-/electron-forge-5.2.4-jrq.6.tgz",
"electron-packager": "electron-userland/electron-packager#7182f9080328dbef79538d384e54c597e103bd32",
"node-abi": "jacobq/node-abi#15baa5fa42a4a379b182d08075f0515a8e9460ec",
},
"resolutions": {
"**/broccoli-postcss": "^4.0.1",
"**/electron-forge": "https://registry.npmjs.org/@jacobq/electron-forge/-/electron-forge-5.2.4-jrq.6.tgz",
"**/electron-packager": "electron-userland/electron-packager#7182f9080328dbef79538d384e54c597e103bd32",
"**/node-abi": "jacobq/node-abi#15baa5fa42a4a379b182d08075f0515a8e9460ec"
},
Hello @jacobq,
I follow your steps and I can execute ember-electron and debug, but not compile...
Using electron-prebuilt-compile with Electron Packager requires specifying an exact Electron version
And If I add
"resolutions": { "**/broccoli-postcss": "^4.0.1", "**/electron-forge": "^5.2.4", "**/electron-packager": "^14.0.1", "**/node-abi": "2.7.1" }
I have different error:
Cannot find module 'electron-packager/targets'
I am using
"electron-prebuilt-compile": "https://registry.npmjs.org/@jacobq/electron-prebuilt-compile/-/electron-prebuilt-compile-3.1.8.tgz",
How can I fix it?
Thanks!
@debelop13
I have different error:
Cannot find module 'electron-packager/targets'
Hmm, what happens if you run yarn
then node
(CLI) and var t = require('electron-packager/targets')
? You should see something like the object here: https://github.com/electron-userland/electron-packager/blob/master/src/targets.js#L84
How can I fix it?
Unfortunately, I'm not sure what's going on in your case, and I've been occupied with other (non-JS) projects over the last month or so. If you'd like to share a repo demonstrating your problem here perhaps I or someone else will be able to help you troubleshoot.
It doesn't look like there is any 3.1.x version published, so when you can, please make one for
3.1.13.1.23.1.43.1.63.1.73.1.83.1.9Likewise for 5.x:
5.0.05.0.1It would be nice to have
4.0.14.0.24.0.34.0.54.0.64.0.84.1.04.1.14.1.24.1.34.1.44.1.54.2.0 also. :pray: