search

electron-userland / electron-spellchecker

Implement spellchecking, correctly
MIT License
238 stars 83 forks source link

Any way to remove/disable a context menu item? #116

Open Nantris opened 6 years ago

Nantris commented 6 years ago

In particular, I'd like to disable the copyImageUrl feature, since all my images are displayed in Base64

WilliamHolmes commented 6 years ago

@Slapbox Potential Hack: you could override the ContextMenuBuilder.isSrcUrlValid function and also check for non base64 url.

Nantris commented 6 years ago

@WilliamHolmes thanks very much. I'm going to investigate this possibility when I get some time. It seems to me that it's pretty safe to simply fork the module at this point since it seems unlikely we'll be seeing future updates unless something breaks catastrophically.

WilliamHolmes commented 6 years ago

@Slapbox I've been overriding the addCopy function successfully so it should also work for you. My original issue hasn't been reviewed.

I don't think this repo is being maintained which is a shame because its a great package.

Nantris commented 6 years ago

It is a shame, but the thin silver lining is the freedom to hack at it to your heart's content and never worry about merging. As long as no update ever does come anyway.