electron-userland / electron-spellchecker

Implement spellchecking, correctly
MIT License
237 stars 83 forks source link

using DictionarySync.preloadDictionaries #119

Open avner-hoffmann opened 6 years ago

avner-hoffmann commented 6 years ago

Is the DictionarySync.preloadDictionaries method still works? According to the docs it should return an Array: https://electron-userland.github.io/electron-spellchecker/docs/class/src/dictionary-sync.js~DictionarySync.html

However according to the code in the docs it actually returns a Promise<Array>: https://electron-userland.github.io/electron-spellchecker/docs/file/src/dictionary-sync.js.html#lineNumber116

Whereas the code in the repository is this: preloadDictionaries() { // NB: This is retained solely to not break earlier versions return Observable.of(true); }

The docs then isn't updated. Is this method still working? If so, what should I expect it to return? If not, how can I accomplish that the spell checker will auto identify and add the needed dictionaries according to the keyboard layouts? And what can be done on Mac?

ynaftali-vonage-zz commented 6 years ago

@paulcbetts @felixrieseberg @CharlieHess @kwonoj @blaatunga @danmckeon @dudeofawesome Can you help us here? Please 😊