Let the menu popup default to showing on the currently focused BrowserWindow

electron-userland / electron-spellchecker

Implement spellchecking, correctly

MIT License

237 stars 83 forks source link

Let the menu popup default to showing on the currently focused BrowserWindow #131

Closed leekevinyg closed 5 years ago

leekevinyg commented 5 years ago

It looks like menu.popup() defaults to the currently focused BrowserWindow now, so there is no need to specify it with remote.getCurrentWindow(). This change also workarounds an issue where remote.getCurrentWindow() may return null in some environments, resulting in a popup to not appear as expected.