Versions >2.0.0 no longer work in Electron 4

electron-userland / electron-spellchecker

Implement spellchecking, correctly

MIT License

238 stars 83 forks source link

Versions >2.0.0 no longer work in Electron 4 #145

Open Nantris opened 5 years ago

Nantris commented 5 years ago

Upgrading causes the spellchecker to fail silently and not highlight any misspelling. I tried removing all my node_modules and reinstalling, but no luck.

ouassimBenMosbah commented 5 years ago

I can confirm. It is working fine with electron 4.2.2 and electron-spellchecker 1.1.2 while it isn't with electron 4.2.2 and electron-spellchecker 2.0.0

Nantris commented 5 years ago

@ouassimBenMosbah 2.0.0 works for me on Electron@4.1.x, but anything above that does not. The spellcheck library it imports/requires changes in one of the versions after 2.0.0 which I suspected was the source of my issue.