search

electron-userland / electron-spellchecker

Implement spellchecking, correctly
MIT License
238 stars 83 forks source link

Cannot find module 'debug/browser' #33

Closed beljand closed 7 years ago

beljand commented 7 years ago

I'm using MacOS, Node 6.5.0, Electron 1.4.6, Webpack 1 and Typescirpt. When I try to import the plugin, I get an error that debug/browser module is missing. This error accrues only when app is bundled to .app, not when I run electron app. Any ideas?

module.js:457 Uncaught Error: Cannot find module 'debug/browser' at Module._resolveFilename (module.js:455:15) ....

This was resolved with version 0.7.1

beljand commented 7 years ago

Using v0.7.1

fs.js:640 Uncaught Error: ENOENT: no such file or directory, open '/Users/user/project/dist/mac/4th Office.app/Contents/Resources/app.asar.unpacked/node_modules/spawn-rx/lib/index.js'

I got this error in dev console, but only in a packed application (using electron-packager). If I start the app with electron everything works fine.

For now I think it's an issue with re-building modules for Electron and I'm concerned about Jobber.exe (since I'm on a Mac)

anaisbetts commented 7 years ago

@beljand Jobber is only used on Windows, on macOS process groups work properly :)

Why is spawn-rx being searched for in the unpacked part of the ASAR archive? spawn-rx is not a native module, it's all JavaScript

beljand commented 7 years ago

For the purpose of testing I have disabled asar, now packaging works for MacOS, but not for Linux/Win builds

keyboard-layout@2.0.7 install /project/node_modules/keyboard-layout node-gyp rebuild make: Entering directory '/project/node_modules/keyboard-layout/build' CXX(target) Release/obj.target/keyboard-layout-manager/src/keyboard-layout-manager-linux.o In file included from ../src/keyboard-layout-manager-linux.cc:1:0: ../src/keyboard-layout-manager.h:7:22: fatal error: X11/Xlib.h: No such file or directory compilation terminated. keyboard-layout-manager.target.mk:96: recipe for target 'Release/obj.target/keyboard-layout-manager/src/keyboard-layout-manager-linux.o' failed make: *** [Release/obj.target/keyboard-layout-manager/src/keyboard-layout-manager-linux.o] Error 1 make: Leaving directory '/project/node_modules/keyboard-layout/build'

anaisbetts commented 7 years ago

You're missing libxkbfile-dev. These are all separate issues, so maybe open them separately?