search

electron-userland / electron-spellchecker

Implement spellchecking, correctly
MIT License
239 stars 83 forks source link

Spellchecker on Mac doesn't automatically detect the language #61

Open clusterberries opened 7 years ago

clusterberries commented 7 years ago

Hi! I've run the example app on Windows and on Mac, system language is English on both systems. The language is correctly detected on Windows, I tried English and Russian. But it doesn't work on Mac, see the screenshot. The last Russian word should be highlighted. Spellcheck works only for English language. screen shot 2017-04-17 at 11 48 01

mediaslav commented 7 years ago

I can confirm that, detection fails on Mac

anaisbetts commented 7 years ago

Language detection is done solely by NSSpellChecker, which means that switching between different character sets is gonna have a bad time right now. Chromium won't even send you spell check requests for a language other than the set one - on Windows, we detect this scenario (i.e. keys are being typed but no spell check requests are coming in), redetect the language, then switch the Chromium spellcheck component. We need to ditch NSSpellChecker's detection and rely on our own.

akashnimare commented 7 years ago

@paulcbetts Any update on this? The spellchecker doesn't detect language automatically on macOS. On other OS it works pretty well.