neurosnap
commented
6 years ago My build is now breaking because of #88 on latest update of xcode.
What's the status of this PR?
Closed tommoor closed 5 years ago
neurosnap
commented
6 years ago My build is now breaking because of #88 on latest update of xcode.
What's the status of this PR?
tommoor
commented
6 years ago I'll have to update to the GM and latest Xcode later today and see if I can reproduce. It could be that both fixes are needed in reality.
bengotow
commented
6 years ago Hey folks—ran into this problem after updating Xcode today I can confirm that switching from 1.0.1 to this PR (tommoor/electron-spellchecker#ba984b5ae1abf78bf11c5de9363a60e1f261712f) fixes the issue using the Xcode 9 GM and High Sierra.
Why does this lower the version of spellchecker though? Is the problem that the newer versions are all impacted by the static issue? If so we should probably just fix that.
tommoor
commented
6 years ago @bengotow it seems like @paulcbetts went up a bunch of versions on his own branch (he might have more insight), I just changed it to the latest version in the mainline.
neurosnap
commented
6 years ago I've been trying to get this to work but it looks like there were a number of changes to node-spellchecker to make electron-spellchecker work properly. I was able to get windows to work but linux is not working. The root cause seems to be hunspell not working correctly with electron-spellchecker.
You can track my progress here: https://github.com/notion/electron-spellchecker/pull/1
felixrieseberg
commented
5 years ago Solid changes (and I'm cleanup up a bit here), but now behind. Closing.
Apologies for never acting on any of this sooner, this was all a bit before my time 🙈
In my testing this resolves the issues building on High Sierra however I'm only testing on Mac so it's possible these updates affect other platforms. It would be great to get some more testing.
closes https://github.com/electron-userland/electron-spellchecker/issues/88