search

electron-userland / electron-spellchecker

Implement spellchecking, correctly
MIT License
237 stars 83 forks source link

High Sierra bug present in v1.2.0 #96

Closed alanshaw closed 6 years ago

alanshaw commented 6 years ago

In my package.json I depend on "electron-spellchecker": "^1.0.4",

When I npm install I believe it tries to install 1.2.0 and fails with this issue #88.

I was hoping to get v1.1.2 with the macOS High Sierra fix, but it appears someone has published a v1.2.0 version before v1.1.2 that doesn't include the fix:

$ npm view electron-spellchecker time
npm http request GET https://registry.npmjs.org/electron-spellchecker
npm http 200 https://registry.npmjs.org/electron-spellchecker

{ modified: '2017-10-05T17:43:46.953Z',
  created: '2016-06-10T20:56:45.586Z',
  '0.0.1': '2016-06-10T20:56:45.586Z',
  /* ... */
  '1.1.0': '2017-06-08T18:25:44.794Z',
  '1.1.1': '2017-07-14T09:01:31.633Z',
  '1.2.0': '2017-07-14T20:40:25.205Z',
  '1.1.2': '2017-10-05T17:43:46.953Z' }

Can you please release a v1.3.0 that includes the fix?

alanshaw commented 6 years ago

🙄 sorry, npm had dropped a package-lock.json in the project so I was just getting the same old version each time, this is not because of the v1.2.0 version that was published (this doesn't matter because the "latest" version in npm is set to v1.1.2)...non issue, please ignore.