search

electron-userland / electron-webpack

Scripts and configurations to compile Electron applications using webpack
https://webpack.electron.build/
903 stars 170 forks source link

Can you push update so there was support of Webpack 5? #454

Open creotiv opened 2 years ago

phryneas commented 2 years ago

I have forked this and made it run with webpack 5 - you can find the fork here: https://github.com/phryneas/electron-webpack

Please note that I only did this as part of a spike to evaluate different build systems, so "running" for me does not mean that I covered every possible edge case - and depending if we use it for our product, it might get any updates & maintenance or not. But it might be a good starting point for others.

Bartel-C8 commented 1 year ago

@phryneas How can I install your fork via yarn/npm?

phryneas commented 1 year ago

@Bartel-C8 I only built it locally with yalc and didn't end up switching over to webpack 5, so you'd have to build it yourself.

Bartel-C8 commented 1 year ago

Thanks, got to install it (just now) with the help of: https://gitpkg.vercel.app/

yarn add -D 'https://gitpkg.now.sh/phryneas/electron-webpack/packages/electron-webpack?master'

EDIT: the above did not work ofc, as it is not built (as a running binary).

Why did you not switch to webpack 5? Some major issues?

phryneas commented 1 year ago

Ah sorry, this is the electron repo. Correct answer here is that I didn't end up electron at all, but went with tauri.