electron-userland / electron-windows-store

:package: Turn Electron Apps into Windows AppX Packages
MIT License
678 stars 86 forks source link

MakeAppx fails with certificate issued to name with comma #103

Open FilipChalupa opened 6 years ago

FilipChalupa commented 6 years ago
MakeAppx : error: Error info: error C00CE169: App manifest validation error: The app manifest must be valid as per schema: Line 8, Column 5, Reason: 'CN=manGoweb, s.r.o.' violates pattern constraint of '(CN|L|O|OU|E|C|S|STREET|T|G|I|SN|DC|SERIALNUMBER|Description|PostalCode|POBox|Phone|X21Address|dnQualifier|(OID\.(0|[1-9][0-9]*)(\.(0|[1-9][0-9]*))+))=(([^,+="<>#;])+|".*")(, ((CN|L|O|OU|E|C|S|STREET|T|G|I|SN|DC|SERIALNUMBER|Description|PostalCode|POBox|Phone|X21Address|dnQualifier|(OID\.(0|[1-9][0-9]*)(\.(0|[1-9][0-9]*))+))=(([^,+="<>#;])+|".*")))*'.
The attribute 'Publisher' with value 'CN=manGoweb, s.r.o.' failed to parse.
jmcrthrs commented 4 years ago

Hey @FilipChalupa, did you find a resolution to this? I am also having issues because my published name contains quotes and commas.

FilipChalupa commented 4 years ago

@jmcrthrs, I don't have any updates on that. (I was thinking about creating a new certificate without commas. 🤦‍♂️)

jameshfisher commented 4 years ago

Duplicate of https://github.com/felixrieseberg/electron-windows-store/issues/82

jameshfisher commented 4 years ago

Should be fixed in https://github.com/felixrieseberg/electron-windows-store/pull/131; in the mean time the correct (but confusing) way to use this package is like so:

const convertToWindowsStore = require('electron-windows-store');
convertToWindowsStore({
    identityName: '12345MyCompany.Ghost',  // This is actually the package name!
    packageName: 'Ghost',  // This is actually the application id!!
    // ...
});