electron-userland / electron-windows-store

:package: Turn Electron Apps into Windows AppX Packages
MIT License
681 stars 87 forks source link

Microsoft provides an identity name and family name that the program won't accept #120

Open ncodeyx opened 5 years ago

ncodeyx commented 5 years ago

Microsoft provides an identity name and family name starting with numbers. When attempting to build with supplied packageIdentity and packageName, i get the following error:

MakeAppx : error: Error info: error C00CE169: App manifest validation error: The app manifest must be valid as per schema: Line 26, Column 18, Reason: '238....' violates pattern constraint of '([A-Za-z][A-Za-z0-9])(.[A-Za-z][A-Za-z0-9])*'. The attribute 'Id' with value '238...' failed to parse.

Microsoft doesn't allow me to upload it to their store without this being fulfilled.

ncodeyx commented 5 years ago

Looks like only identityName needs to be filled out and not the family ID. You should make this more clear in the documentation.

jameshfisher commented 4 years ago

Duplicate of https://github.com/felixrieseberg/electron-windows-store/issues/82

jameshfisher commented 4 years ago

Should be fixed in https://github.com/felixrieseberg/electron-windows-store/pull/131; in the mean time the correct (but confusing) way to use this package is like so:

const convertToWindowsStore = require('electron-windows-store');
convertToWindowsStore({
    identityName: '12345MyCompany.Ghost',  // This is actually the package name!
    packageName: 'Ghost',  // This is actually the application id!!
    // ...
});
jameshfisher commented 4 years ago

I've since come to the conclusion that the right way to use electron-windows-store is to write your own AppxManifest.xml, and pass this in, like so

const convertToWindowsStore = require('electron-windows-store');
convertToWindowsStore({
    manifest: '.\\AppXManifest.xml',  // For many reasons, we write should own
    packageName: 'Ghost',  // Still needed for filename 'Ghost.appx'
    // ...
});