search

electron-userland / electron-windows-store

:package: Turn Electron Apps into Windows AppX Packages
MIT License
677 stars 86 forks source link

Signtool fails when using p12 certificate. #32

Closed BradNewton closed 7 years ago

BradNewton commented 8 years ago

We have a certificate with an extension of p12, when I try to use this I get the following error: SignTool Error: The specified PFX password is not correct. I've tried adding to the command line: signtool-params "/fd SHA256","/p password" I've also imported the certificate to the certificate store on my PC.

I am able to sign the file as a separate step using: signtool sign /f path\Cert.p12 /fd SHA256 /p password appname.appx

felixrieseberg commented 8 years ago

Hey! Thanks for reporting - this isn't exactly a bug, given that we currently only support PFX signing. However, I'd <3 a PR that extends this piece of code with a quick if/else detection to see if the user supplied a p12 (and then to change the arguments).

@BradNewton: Wanna take a crack at it :bow: ?

ChrisK2 commented 8 years ago

There is another actual bug: signtool only processes parameters up to the appx-filename, everything afterwards is silently ignored. Unfortunately, exactly this is done with the parameters supplied using the --signtool-params option, so anything you specifiy there is ignored.

felixrieseberg commented 8 years ago

@ChrisK2 Yep, that's a real bug - I'll fix that real quick.

felixrieseberg commented 8 years ago

Patched and published!