electron-userland / electron-windows-store

:package: Turn Electron Apps into Windows AppX Packages
MIT License
677 stars 86 forks source link

Unknown error, events.js:160 #42

Open black-snow opened 7 years ago

black-snow commented 7 years ago

Ran electron-windows-store inside my build folder. Stepped through the questions:

It then starts flattening etc., starting conversion, cleaning output folder, copying data, and after printing Creating manifest.. this is what happens:

events.js:160
    throw er; // Unhandled 'error' event
    ^

Error: spawn ...x86\makeappx.exe ENOENT
    ...

Can't tell what went wrong. Any way to debug this?

Win 10 Pro @32bit, Version 1511 (Build 10586.589) node v6.2.1 Windows SDK 10.1.10586.212 electron-windows-store: latest

felixrieseberg commented 7 years ago

We apparently have trouble finding the makeappx binary. Let me dig for a moment, but this should be totally fixable.

felixrieseberg commented 7 years ago

Looking at the code, I sadly couldn't find anything super obvious. Could you do me a favor and check where exactly makeappx.exe is on your machine?

black-snow commented 7 years ago

Sure, will do tomorrow (Europe/Berlin).

black-snow commented 7 years ago

@felixrieseberg makeappx.exe is at C:\Program Files\Windows Kits\10\bin\x86 instead of C:\Program Files (x86)\Windows Kits\10\bin\x86.

Works using C:\Program Files\Windows Kits\10\bin\x86.

Should we modify the default path?

clusterberries commented 7 years ago

For me this path looks like C:\Program Files (x86)\Windows Kits\10\bin\10.0.15063.0\x64

rptwsthi commented 5 years ago

Any thing on this thread, when I try to execute:

electron-windows-store --input-directory D:\Arpit\GSWindows\GSLive\GSDesktop --output-directory D:\Output --package-version 1.0.0.0 --package-name GSDesktop

Inside WindowsPowerCell it gives same error:

events.js:167 throw er; // Unhandled 'error' event ^

Error: spawn C:\Program Files (x86)\Windows Kits\10\bin\x64\makeappx.exe ENOENT at Process.ChildProcess._handle.onexit (internal/child_process.js:232:19) at onErrorNT (internal/child_process.js:407:16) at process._tickCallback (internal/process/next_tick.js:63:19) Emitted 'error' event at: at Process.ChildProcess._handle.onexit (internal/child_process.js:238:12) at onErrorNT (internal/child_process.js:407:16)

rptwsthi commented 5 years ago

Updated my request to this and one part of it worked fine:

electron-windows-store --input-directory D:\Arpit\GSWindows\GSLive\GoSesstionDesktop --output-directory D:\Output --package-version 1.0.0.0 --windows-kit 'C:\Program Files (x86)\Windows Kits\10\App Certification Kit' --desktop-converter 'C:\Users\DELL\AppData\Local\Microsoft\WindowsApps\Microsoft.DesktopAppConverter_8wekyb3d8bbwe' --publisher CN=IfConditions ` --package-name GoSession

rptwsthi commented 5 years ago

Now I am facing another issue, though the package is created yet I am not able to install the using this : Package as there is some issue with certificate.

Package creation succeeded.

Error information: "Error: Store IsDiskFile() failed." (-2147024893/0x80070003)

SignTool Error: An unexpected internal error has occurred.

Error: C:\Program Files (x86)\Windows Kits\10\App Certification Kit\signtool.exe exited with code: 1 at ChildProcess.child.on (C:\Users\DELL\AppData\Roaming\npm\node_modules\electron-windows-store\lib\utils.js:74:23) at ChildProcess.emit (events.js:182:13) at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12) Error: C:\Program Files (x86)\Windows Kits\10\App Certification Kit\signtool.exe exited with code: 1 at ChildProcess.child.on (C:\Users\DELL\AppData\Roaming\npm\node_modules\electron-windows-store\lib\utils.js:74:23) at ChildProcess.emit (events.js:182:13) at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12) PS D:\Arpit\GSWindows\GSLive\GoSesstionDesktop>

richiedevs commented 4 years ago

I got the same issue too, idk why

nfplay commented 4 years ago

@rptwsthi and @MysticCraftYT , at this time you've probably already guessed that you're missing the path to your pfx developer certificate using the option '--dev-cert' :)