search

electron-userland / electron-windows-store

:package: Turn Electron Apps into Windows AppX Packages
MIT License
678 stars 86 forks source link

added identityName and missing dep chalk #59

Closed EragonJ closed 7 years ago

EragonJ commented 7 years ago

@felixrieseberg plz give this PR a check.

In order to make a valid .appx for windows app store, I need to customize this field with https://github.com/felixrieseberg/electron-windows-store/commit/6b42f501d9587c3fb93ec512172f44d639f4e57b together to make it work.

EragonJ commented 7 years ago

I checked that from windows developer panel and mine shows something like : "mycompanyname.01234A8BB72DA" (I already marked some sensitive info but it looks like this)

since the string after "." is created randomly by microsoft, I think this should be customized by developer themselves. No matter how, I still fallback to original option to make sure it's backward compatible.

felixrieseberg commented 7 years ago

Thank you very much, I'll push this out as an update right away!