search

electron-userland / electron-windows-store

:package: Turn Electron Apps into Windows AppX Packages
MIT License
678 stars 86 forks source link

Assets scale not being recognized #63

Closed ahadcove closed 6 years ago

ahadcove commented 7 years ago

I am trying to add my custom assets folder to add icons to my appx installer. For some reason it is not recognizing that these are the icons I want to use and is defaulting to the samples. My folder does copy to the correct place and all of my icons are

Logo.scale-44.png
Logo.scale-50.png
Logo.scale-150.png
Logo.scale-310.png

And my config is:

        "assets": "./build/appxAssets/"

But, the appx still defaults to the samples instead

stefanhuber commented 7 years ago

Is this working?

ahadcove commented 7 years ago

For some reason the manifest still doesnt pick up my assets folder. They continue to use the default samples

stefanhuber commented 7 years ago

Inside the template for the manifest the respective values are hardcoded... So one has to use the same names.

https://github.com/felixrieseberg/electron-windows-store/blob/master/template/appxmanifest.xml

ahadcove commented 7 years ago

Ohhh I see

ahadcove commented 7 years ago

Trying it out now

felixrieseberg commented 6 years ago

One could just overwrite the manifest - this module supports that already.