search

electron-userland / electron-windows-store

:package: Turn Electron Apps into Windows AppX Packages
MIT License
678 stars 86 forks source link

Add makecert option to skip certificate installation #72

Closed jacobq closed 7 years ago

jacobq commented 7 years ago

It would be nice for consuming apps to be able to call makeCert to create a certificate without adding it to the system's certificate store. Other than add flexibility, I'm not sure if there are other legitimate use cases, but without this an unprivileged user may run into an error like this:

Import-PfxCertificate : Access is denied. (Exception from HRESULT: 0x80070005

(E_ACCESSDENIED))
At line:1 char:1
+ Import-PfxCertificate -FilePath C:\Users\Jacob\AppData\Local\Temp\ele ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Import-PfxCertificate], UnauthorizedAccessException
    + FullyQualifiedErrorId : System.UnauthorizedAccessException,Microsoft.CertificateServices.Commands.ImportPfxCertificate
felixrieseberg commented 7 years ago

Seems like a solid change, I'll merge it in. Code 👀 good, too!