electron-userland / electron-windows-store

:package: Turn Electron Apps into Windows AppX Packages
MIT License
678 stars 86 forks source link

Fix: makeCert argument typos introduced in #69 #74

Closed jacobq closed 7 years ago

jacobq commented 7 years ago

Take a look, but I suspect this will fix #73 Sorry my mistake broke something :(

jacobq commented 7 years ago

@felixrieseberg Do you think it'd be hard to write some tests for the setup module? I didn't realize there weren't any or I might have been a bit more careful (or even added some).

felixrieseberg commented 7 years ago

Hey! Don't beat yourself up over this, we're all working for free here. I'm super happy you're making contributions :clap:

I didn't get to write tests, but we should probably have some.