electron-userland / electron-windows-store

:package: Turn Electron Apps into Windows AppX Packages
MIT License
681 stars 87 forks source link

Documentation for `makepri` is unecessarily obfuscated #93

Open tcoulter opened 7 years ago

tcoulter commented 7 years ago

Hi there,

First off, thanks for electron-windows-store. I wouldn't have a Windows store app without it.

That said, I spent nearly two days fighting with logo images and the AppXManifest.xml file trying to get unplated icons to show up in the taskbar (I'm making a desktop app). Turns out, makePri needs to be true. Such a simple fix, and if only I would have known this ahead of time!

In the docs, you specify this for the makePri option:

--make-pri <true|false> Use makepri.exe (you don't need to unless you know you do)

I can't tell you what makepri.exe does, or what "pri" means, but after finally going down every rabbit hole (and stumbling upon this package), now I know I need makePri on. Would be great to change the documentation to reflect makePri's usefulness, in hopes to save time for everyone else.

As an aside, I believe setting makePri to true is the fix for #55.

Thanks!