search

electron-userland / electron-windows-store

:package: Turn Electron Apps into Windows AppX Packages
MIT License
678 stars 86 forks source link

RangeError: Maximum call stack size exceeded during "Cleaning pre-appx output folder..." when user folder contains spaces #95

Open uffou opened 6 years ago

uffou commented 6 years ago

Hi there,

I am getting the following error and don't really have a clue why...

--input-directory C:\Users\Vasil Enchev\Documents\Repos\ora-app\release-builds\Ora-win32-ia32  --output-directory C:\Users\Vasil Enchev\Documents\Repos\ora-app\ora-appx\

Configuration:
Desktop Converter Location:    false
Expanded Base Image:           false
Publisher:                     CN=A6A54C5B-0F15-474E-B6FA-xxxxxxxxxx
Dev Certificate:               C:\Users\Vasil Enchev\AppData\Roaming\electron-windows-store\A6A54C5B-0F15-474E-B6FA-C5E1B5067B5\A6A54C5B-0F15-474E-B6FA-C5E1B5067B067B5.pfx
Windows Kit Location:          C:\Program Files (x86)\Windows Kits\10\bin\10.0.16299.0\x64

? We recommend flattening node_modules. Are you okay with us flattening all node_modules folders inside your input directory? Yes
? Please enter your app's package name (name of your exe - without '.exe'):  Ora
? Please enter your app's package version:  1.0.0.0
Flattening modules...
Starting Conversion...
Cleaning pre-appx output folder...
RangeError: Maximum call stack size exceeded
    at Array.forEach (<anonymous>)
    at defaults (C:\Users\Vasil Enchev\AppData\Roaming\npm\node_modules\electron-windows-store\node_modules\fs-extra\lib\remove\rimraf.js:18:11)
    at rimrafSync (C:\Users\Vasil Enchev\AppData\Roaming\npm\node_modules\electron-windows-store\node_modules\fs-extra\lib\remove\rimraf.js:229:3)
    at options.readdirSync.forEach.f (C:\Users\Vasil Enchev\AppData\Roaming\npm\node_modules\electron-windows-store\node_modules\fs-extra\lib\remove\rimraf.js:291:39)
    at Array.forEach (<anonymous>)
    at rmkidsSync (C:\Users\Vasil Enchev\AppData\Roaming\npm\node_modules\electron-windows-store\node_modules\fs-extra\lib\remove\rimraf.js:291:26)
    at rmdirSync (C:\Users\Vasil Enchev\AppData\Roaming\npm\node_modules\electron-windows-store\node_modules\fs-extra\lib\remove\rimraf.js:281:7)
    at rimrafSync (C:\Users\Vasil Enchev\AppData\Roaming\npm\node_modules\electron-windows-store\node_modules\fs-extra\lib\remove\rimraf.js:252:7)
    at options.readdirSync.forEach.f (C:\Users\Vasil Enchev\AppData\Roaming\npm\node_modules\electron-windows-store\node_modules\fs-extra\lib\remove\rimraf.js:291:39)
    at Array.forEach (<anonymous>)
RangeError: Maximum call stack size exceeded
    at Array.forEach (<anonymous>)
    at defaults (C:\Users\Vasil Enchev\AppData\Roaming\npm\node_modules\electron-windows-store\node_modules\fs-extra\lib\remove\rimraf.js:18:11)
    at rimrafSync (C:\Users\Vasil Enchev\AppData\Roaming\npm\node_modules\electron-windows-store\node_modules\fs-extra\lib\remove\rimraf.js:229:3)
    at options.readdirSync.forEach.f (C:\Users\Vasil Enchev\AppData\Roaming\npm\node_modules\electron-windows-store\node_modules\fs-extra\lib\remove\rimraf.js:291:39)
    at Array.forEach (<anonymous>)
    at rmkidsSync (C:\Users\Vasil Enchev\AppData\Roaming\npm\node_modules\electron-windows-store\node_modules\fs-extra\lib\remove\rimraf.js:291:26)
    at rmdirSync (C:\Users\Vasil Enchev\AppData\Roaming\npm\node_modules\electron-windows-store\node_modules\fs-extra\lib\remove\rimraf.js:281:7)
    at rimrafSync (C:\Users\Vasil Enchev\AppData\Roaming\npm\node_modules\electron-windows-store\node_modules\fs-extra\lib\remove\rimraf.js:252:7)
    at options.readdirSync.forEach.f (C:\Users\Vasil Enchev\AppData\Roaming\npm\node_modules\electron-windows-store\node_modules\fs-extra\lib\remove\rimraf.js:291:39)
    at Array.forEach (<anonymous>)
PS C:\WINDOWS\system32>
uffou commented 6 years ago

Found the reason, my user folder was "Vasil Enchev" (Not my choosing, windows does that when you sign in during setup) So apparently, space in this folder is bad news. I created a new user and now everything works. I will leave this issue open because I think it is something that should be fixed to avoid this happening to other poor souls who signed in during windows setup.

Workaround: Avoid spaces in paths used by electron-windows-store