search

electron-userland / electron-wix-msi

:dvd: Create traditional MSI installers for your Electron app
MIT License
319 stars 93 forks source link

Options for light #114

Closed Qazzian closed 3 years ago

Qazzian commented 3 years ago

This adds the ability to pass command line options to light.exe I found I needed this in order to build my app as part of a Jenkins pipeline which required the -sval option to be set.

I called the configuration parameter lightSwitches partly to fit in with the rest of the wix terminology, but I'm happy to change it to something clearer if you have any suggestions.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 18a43a9040b0483423b3846ad25f2b11782279dd on Qazzian:options-for-light into 4bfb0562240abb9c5e9d1e8157500c9940da3db2 on felixrieseberg:master.

felixrieseberg commented 3 years ago

Thank you, this is a good addition. I'll merge and release a new version!

Qazzian commented 3 years ago

Thanks