search

electron-userland / electron-wix-msi

:dvd: Create traditional MSI installers for your Electron app
MIT License
319 stars 93 forks source link

feat!: rename icon path fields to be consistent #153

Closed georgexu99 closed 2 years ago

georgexu99 commented 2 years ago

Co-authored-by: Keeley Hammond vertedinde@electronjs.org

This change aims to bring icon path config names in line with other electron-forge makers to improve clarity for users.

note that this would be a breaking change as this is an option name, and would need to be communicated in the forge release notes.

related issue: github.com/electron-userland/electron-forge/issues/1994 related guide doc for forge: https://github.com/electron-forge/electron-forge-docs/pull/74/files