search

electron-userland / electron-wix-msi

:dvd: Create traditional MSI installers for your Electron app
MIT License
318 stars 91 forks source link

The code introduces the exe-icon-extractor package inconsistently with the package.json definition #167

Open Sallyfafafa opened 1 year ago

Sallyfafafa commented 1 year ago

The definition uses the @bitdisaster/exe-icon-extractor： https://github.com/electron-userland/electron-wix-msi/blob/master/package.json#L36

The source code uses the exe-icon-extractor https://github.com/electron-userland/electron-wix-msi/blob/master/src/utils/rc-edit.ts#L22

When I use electron-wix-msi to build a windows application, I get a message that exe-icon-extractor cannot be found

Can we standardize?

dineshmedloop commented 1 year ago

any solution?