Open MarshallOfSound opened 7 years ago
Are you seeing this in 3.4.0? Can you reproduce it with 3.3.0?
waitUntilWindowLoaded
was changed in https://github.com/electron/spectron/pull/118 since it previously was swallowing an internal exception every time and resolving itself with an Error
instead of rejecting.
@kevinsawicki It appears to be directly linked with https://github.com/electron/electron/issues/7359
Basically that error is thrown, then this window[requireName]
fails, and then Spectron never terminates. I have to manually kill the process.
https://circleci.com/gh/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/1126?utm_campaign=build-failed&utm_medium=email&utm_source=notification
Recently (without any changes to either my Spectron tests or Spectron config) my Spectron tests have started failing on Linux with this error
I can't reproduce this locally on Windows or macOS so I'm wondering if there is something that has changed recently in Spectron that could have caused this regression.