search

electron-userland / spectron

DEPRECATED: 🔎 Test Electron apps using ChromeDriver
http://electronjs.org/spectron
MIT License
1.68k stars 228 forks source link

spectron.d.ts needs to be updated #201

Closed dschaefer closed 7 years ago

dschaefer commented 7 years ago

Electron now ships with it's own electron.d.ts. spectron.d.ts seems to refer to types/electron which is not the same (and itself conflicts with the new one in electron). In particular, I get:

node_modules/spectron/lib/spectron.d.ts(165,27): error TS2694: Namespace 'Electron' has no exported member 'ElectronMainAndRenderer'.

And indeed Electron does not have such a member. I guess the closest thing would be AllElectron.

zeke commented 7 years ago

@dschaefer can you share the application code you're using that generates this error?

dschaefer commented 7 years ago

I have worked around it in my repos on github. I'll hack at one of them and get it into a reproduceable state.

abhinav2004 commented 7 years ago

@zeke It is reproducible if we use the newer d.ts provided by electron itself. I am using electron v1.6.11. You can refer to this repo: https://github.com/abhinav2004/spectron-dt-1.6.11

As @dschaefer said the closest thing to ElectronMainAndRenderer is AllElectron

kevinsawicki commented 7 years ago

Fixed by #209 and #211 and released in 3.7.2