search

electron-userland / spectron

DEPRECATED: 🔎 Test Electron apps using ChromeDriver
http://electronjs.org/spectron
MIT License
1.68k stars 229 forks source link

WebdriverIO v5 #349

Open eostrom opened 5 years ago

eostrom commented 5 years ago

WebdriverIO 5.0 is out. I started modifying Spectron to use it. I didn't get very far, but if anyone else wants to press forward, my work is in https://github.com/eostrom/spectron/tree/webdriverio-5.

vladimiry commented 5 years ago

It would be awesome to get webdriver 5 supported as it comes with significantly improved typescript typings.

christian-bromann commented 5 years ago

Hey 👋 ,

this is Christian from the WebdriverIO team. Is there any chance I can help with this issue? @eostrom ?

Cheers

eostrom commented 5 years ago

Hi @christian-bromann. I've moved on from the project I was using Spectron for, but if you want to pursue the WebdriverIO upgrade you are more than welcome to use the branch above as a starting point. There's just one commit, and it's mostly renaming things... plus it looks like I simplified client initialization using a promise returned from WebDriver.remote.

There may be mistakes, I wasn't able to test thoroughly.

rebeccadallorso commented 5 years ago

@christian-bromann, if this is an issue that is being picked up and worked on - myself and I know a few others would love to help out as well. This fix would help streamline to have our webpage tests line up with our electron tests, which we would love to see!

christian-bromann commented 5 years ago

@codebytere is this being planned to get picked up or is community involvement expected?

codebytere commented 5 years ago

I can try to help but unfortunately the core team does not have the bandwidth to proritize this right now.

shahidmau commented 4 years ago

Is there any progress on this?

s4m0r4m4 commented 4 years ago

+1 to this, would love to see spectron upgraded to the latest webdriverio --> v6 just came out a few days ago. https://www.npmjs.com/package/webdriverio

Right now I get npm install warnings since spectron has a dependency chain to an outdated versions of core-js, request, and other packages through webdriverio. I even get a warning about webdriverio being outdated: npm WARN deprecated webdriverio@4.14.4: outdated version, please use @next

smariel commented 4 years ago

It would be very appreciated to move to WebDriverIO v5 or v6 since the v4 website is no longer online anymore. Fortunately, the API page is still available.

For now, adding webdriverOptions: {'deprecationWarnings': false} clears up the tests results.

alexandramedway commented 4 years ago

PR is now up for updating to v5: https://github.com/electron-userland/spectron/pull/631