search

electron-userland / spectron

DEPRECATED: 🔎 Test Electron apps using ChromeDriver
http://electronjs.org/spectron
MIT License
1.68k stars 229 forks source link

Breaking changes from v11.0.0 -> v11.1.0 #647

Open nklayman opened 4 years ago

nklayman commented 4 years ago

I found a few breaking changes with the 11.1.0 release.

First, client.getHTML was removed because of the upgraded webDriver version.

Second, client.getRendererProcessLogs doesn't return all logs, just some electron warnings. I think it may have been caused by https://github.com/electron-userland/spectron/commit/9fdb35322075f565cc649da9bd1fa3601bd87ab2#diff-5372f626ee15242f1e2c6eb31655b4faR279

I made an example repo to show these changes. Clone it, run yarn to install deps, then run yarn test:unit. All tests should pass. Then, run yarn add spectron@11.1.0 to upgrade spectron, and yarn test:unit will fail.

feross commented 4 years ago

11.1.0 should have been released as 12.0.0.

catdad commented 4 years ago

I just experienced the same issue. Webdriverio v5 was a major breaking change from v4, and it is not a drop-in replacement.

Can we get some guidance on whether there will be an 11.x version to revert this breaking change, or if we are just going to have to live with it (which in this case is not great, but considering the rapid development and versioning, we would just have to deal with it anyway in a couple of weeks)?