Closed menelike closed 8 years ago
@menelike this is crashing on start for me:
@markoshust I'm getting the same error but it builds the osx packages just fine and meteor runs afterwards without any problems. Does it really crash?
@menelike yea, mine won't build at all.
there are also a lot of defaults missing which lead to a lot of headaches getting this to actually execute. in my opinion, it should work without any settings.json file at all. if a settings.json is defined, it should work with a minimally defined one:
{
"electron": {
"name": "My App",
"version": "0.0.1"
}
}
there needs to be sensible defaults in place, especially for the Meteor.settings.electronBuilder
prop. i find it really odd that Meteor.settings.electronBuilder.devMetadata.build
and Meteor.settings.electronBuilder.devMetadata.directories.buildResources
both need to be defined in order for this to build. with the current package, I just meteor add
it, and it all works flawlessly. that's probably how this new build should work as well.
good job refactoring the code though, appears to be a lot of improvements 👍
fyi also, the build is SOOO much different, I'd suggest to keep this in a separate builder/name and remove it from the fork so we can raise issues on your github. i don't think it would be appropriate to merge this into this project.
@markoshust thanks for sharing.
in my opinion, it should work without any settings.json file at all
We still have to make sure that the package runs out of the box, thanks for that!
fyi also, the build is SOOO much different, I'd suggest to keep this in a separate builder/name and remove it from the fork so we can raise issues on your github. i don't think it would be appropriate to merge this into this project.
We moved to https://github.com/risetechnologies/meteor-electron-builder , still some work todo until the first release.
We needed some missing features and needed to build for win/lin/osx.
We ended up with a fork on https://github.com/risetechnologies/meteor-electron which also moved from
electron-packager
toelectron-builder
.Why?
This project reinvents the wheel times too often, as a result it tries to solve all problems
electron-builder
andnuts
already solved.This is what we've done:
electron-builder
withelectron-packager
Still rough and not tested very well, but at least we could easily build from osx for win/lin/osx.
As a lot of breaking changes have been done, I'm not sure if a merge is applicable. What do you think?