search

electron-webapps / meteor-electron

Meteor Electron, the easiest way to create a desktop Meteor application
MIT License
326 stars 48 forks source link

Electron 1.3.3 #96

Closed CarlQLange closed 6 years ago

CarlQLange commented 8 years ago

Something's broken with the electron-rebuild package though. 😢 sadly I have exactly zero idea of what it might be. This works, but probably won't fully function for proper apps.

wallynm commented 8 years ago

I was so happy to see this PR, the rebuild process isn't working? i will try to update and see what happens!

CarlQLange commented 8 years ago

Some of it's working, but this is happening when you uncomment this.

menelike commented 8 years ago

I got it working on the latest Electron (1.3.5) including some other PR and fixes. Runs stable on OSX. If it works well for you we could switch to a new PR.

https://github.com/risetechnologies/meteor-electron

master branch is still under development

CarlQLange commented 8 years ago

👍 I don't mind! I don't really use Electron, so someone else should probably check it out. I'm happy to close this or have it closed in favour of a PR that knows what it's doing :)

menelike commented 8 years ago

FYI: We rewrote everything to electron-builder, see https://github.com/electron-webapps/meteor-electron/issues/104 We currently prefer a permanent fork as we're not sure if this project is still maintained. A PR might follow in the future.

CarlQLange commented 6 years ago

¯_(ツ)_/¯ gonna close this, I expect that at this point there's a better way to do this and this project appears unmaintained. Have a good day everyone!