Closed bradennapier closed 7 years ago
👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.
Update: I have narrowed this down toaws-sdk
being the most likely cause. It seems importing any aws-sdk related package will crash the app eventually.
All I need to do is add
import 'aws-sdk'
anywhere and boom - crash
On further examination, it actually looks like it could be a bug within node.js itself. It looks like they had some issues with Promise / AsyncHooks that has been resolved in recent versions.
I think Electron will need to make sure 1.8.0 is a later version of node than 8.2.1.
@bradennapier According to Node's changelog and our own commits log, Node 8.2.1 is not affected by nodejs/node#13237, so it is something else causing the crash.
@bradennapier Can you run your app via terminal? It could print the error message into stderr.
It turns out we still need to turn on a flag in V8.
Do you still need it or does the flag resolve the issue? I am not on 1.8.0 anymore but if it is something you need I would be happy to upgrade again and check.
The new flag should be able to fix the issue, but please let know if you still see the crash in new 1.8.x release.
Unfortunately this does not appear to be fixed. Still crashes on 1.8.1. Can we re-open this please?
Expected behavior
Dont crash
Actual behavior
Crashes
How to reproduce
I'm really not sure why it does this. It appears to load to a certain point then fails. I am not really sure how to debug it properly since it doesn't really give very good errors and the chrome dev tools crashes as well immediately.
I know it's beta, just thought I would report it so that y'all can make sure to fix it before release :-).
I also get this, which I assume is related to the { type: "texture" } setting that I am using (and never has appeared to do a single thing even on older versions )
crash still occurs if i change that value.
According to the crash log it appears to be a seg fault