search

electron / electron

:electron: Build cross-platform desktop apps with JavaScript, HTML, and CSS
https://electronjs.org
MIT License
113.71k stars 15.31k forks source link

Argument type for setVibrancy is missing nullability #20269

Closed Eugeny closed 3 years ago

Eugeny commented 5 years ago

The typings file specifies:

setVibrancy(type: 'appearance-based' | 'light' | 'dark' | 'titlebar' | 'selection' | 'menu' | 'popover' | 'sidebar' | 'medium-light' | 'ultra-dark'): void;

whereas docs suggest that passing null disables vibrancy.

The argument type should be nullable

MarshallOfSound commented 3 years ago

This is fixed in recent versions of Electron