codebytere
commented
4 years ago Please provide a standalone test that a tester could run to reproduce the issue. This makes fixing issues go more smoothly: not only does it ensure the right thing is tested, but it also prevents triage from bottlenecking on making testers write new tests for each new issue.
I'm setting the more-information-needed label for the above reasons. After you've responded, please @ me in a followup comment. This issue will be closed in 7 days if the above cannot be provided.
Thanks in advance! Your help is appreciated.
Issue Details
Expected Behavior
App should quit without crash
Actual Behavior
App crashes when click "Quit" on macOS Dock
To Reproduce
Quit App from macOS Dock (unsure, see additional information below)
Additional Information
Crash report generated by @electron/symbolicate-mac: crash-report.txt
Since I'm not a macOS user, this bug report was forwarded from https://github.com/Rocket1184/electron-netease-cloud-music/issues/52#issuecomment-618149943
This issue should be present since electron@5, according to https://github.com/Rocket1184/electron-netease-cloud-music/issues/52#issuecomment-520143943
The 'will-quit' event was not handled, and on 'before-quit' event, I tried to destroy some BrowserWindow and a Tray, would it matter?
https://github.com/Rocket1184/electron-netease-cloud-music/blob/89f3d6fd37f30787eea476922e096c0507b7773e/src/main/index.js#L102-L128