search

electron / electronjs.org-old

Electron website
https://electronjs.org
MIT License
1.61k stars 652 forks source link

build difficulty #1607

Closed maddhruv closed 4 years ago

maddhruv commented 5 years ago

Whenever I am trying to make any changes in the html templates - views the changes are not reflected in the build

maddhruv commented 5 years ago

/cc @codebytere @zeke

zeke commented 5 years ago

are you running the server with npm run dev?

maddhruv commented 5 years ago

Yes

zeke commented 5 years ago

It looks like nodemon is not configured to watch for changes to .html files: https://github.com/electron/electronjs.org/blob/03f1a81f1cca717646d3ef0de35035530696c1c4/nodemon.json#L2

maddhruv commented 5 years ago

Even if I add html in watch the changes are not occuring

maddhruv commented 5 years ago

no matter if html is down there or not the fresh dev run should build from the available html! which is not

maddhruv commented 5 years ago

@zeke is there any update on this?

BinaryMuse commented 5 years ago

@maddhruv It's possible you were being bitten by the service worker, and were being served cached pages. Do you still have this issue on the latest master? (If you haven't run the site locally since we removed it, you might need to refresh a couple times for the worker to be fully unregistered.)

vhashimotoo commented 4 years ago

Closing due to no response. Please reopen if you still see this problem