search

electron / electronjs.org-old

Electron website
https://electronjs.org
MIT License
1.61k stars 651 forks source link

youtube_video_url field not displaying video anywhere on app pages #3261

Closed scottmathson closed 4 years ago

scottmathson commented 5 years ago

As noted in this PR, I'm not seeing how the youtube_video_url field cited in the contribution guidelines is actually coming into play on-site, on any of these pages.

Dug into other open and closed issues here, alongside searching the source code of pages in production and am not seeing videos displayed anywhere.

/cc @zeke @ckerr

zeke commented 5 years ago

We may have added it to electron-apps and never implemented it on the site. If you're able to open a PR on https://github.com/electron/electronjs.org to add this, that would be much appreciated. 👍

scottmathson commented 5 years ago

Hey @zeke checking back in on this and you're right, looks like that's the case. Will do some work in main website repo there to remedy this 👍

zeke commented 5 years ago

Thanks @scottmathson! I'm not very active on this project nowadays, so if you open a PR please ping @electron/wg-website for review.

kelvinabella commented 4 years ago

Hello! Is issue still up for grabs?

vhashimotoo commented 4 years ago

@kelvinabella Go for it!

kelvinabella commented 4 years ago

@kelvinabella Go for it!

@HashimotoYT It's my first time contributing to open source. Based from my digging on the issue. We need to add youtube_video_url to https://www.electronjs.org/apps/{app-name} if its existing in the yml file. If not so, would appreciate some guidance on where should I start. Thank you!

vhashimotoo commented 4 years ago

@kelvinabella For showing the application we use that file: https://github.com/electron/electronjs.org/blob/master/views/apps/show.html. You can start from that point: https://github.com/electron/electronjs.org/blob/b5110284c9d4d490341aa5340685fc5144a39a7c/views/apps/show.html#L171, here we show the screenshots and here should be the youtube video. For checking if the app has youtube video you can use that example:

{{#if app.youtube_video_url}}
Show video
{{/if}}
kelvinabella commented 4 years ago

@kelvinabella For showing the application we use that file: https://github.com/electron/electronjs.org/blob/master/views/apps/show.html. You can start from that point:

https://github.com/electron/electronjs.org/blob/b5110284c9d4d490341aa5340685fc5144a39a7c/views/apps/show.html#L171

, here we show the screenshots and here should be the youtube video. For checking if the app has youtube video you can use that example:

{{#if app.youtube_video_url}}
Show video
{{/if}}

@HashimotoYT Hi. Kindly review my changes. Please let me know if I its okay with you. Thanks!